Add Kolide OSQUERY tables (Part 1+2+3 of 4) #14613
Merged
+14,429
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sharon-fdm
changed the title
sharon-fdm
changed the title
mostlikelee
had a problem deploying
to
Docker Hub
GitHub Actions
Error
…to 14464-first-four-tables
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
reviewed
Nov 1, 2023
There was a problem hiding this comment.
@getvictor possibly a remnant from tables we removed late, but I was able to remove the entire execparsers package
sharon-fdm
commented
Nov 1, 2023
| @@ -14,6 +14,7 @@ on: | |||
|
|
|||
| env: | |||
| ORBIT_VERSION: 1.17.0 | |||
| CGO_ENABLED: 1 | |||
There was a problem hiding this comment.
What is this for?
There was a problem hiding this comment.
@getvictor IIRC it's for building the app_icons table which has a C dependency
There was a problem hiding this comment.
Yes, app_icons have C code that needs to be compiled in. It works on darwin and our CI, but I'm not sure if cross-compiling will work on Windows. @sharon-fdm do we need to support cross-compiling on Windows?
noahtalerman
previously requested changes
Nov 1, 2023
There was a problem hiding this comment.
I proposed some table cuts! They fit a couple themes:
- Duplicate info. We already have a table for it.
- Hard to use. The table is difficult to use. We can improve and add it later
- Value is unclear. We don't understand why a user would want to use this table. Let's learn more before we add these.
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
getvictor
requested changes
Nov 1, 2023
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mostlikelee
dismissed
noahtalerman’s stale review
tables removed, merging this to get it in QAs hands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Kolide tables to orbit